Fix internal error in pivot_wider()
#1614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/testthat/_snaps/pivot-wide.md
Outdated
Comment on lines
349
to
356
| Warning: | ||
| Using an external vector in selections was deprecated in tidyselect 1.1.0. | ||
| i Please use `all_of()` or `any_of()` instead. | ||
| # Was: | ||
| data %>% select(x) | ||
| # Now: | ||
| data %>% select(all_of(x)) |
Member
There was a problem hiding this comment.
We do not want to see this warning in the snapshot output
tests/testthat/test-pivot-wide.R
Outdated
Comment on lines
923
to
931
| # Character vector case | ||
| expect_snapshot(error = TRUE, { | ||
| pivot_wider( | ||
| df, | ||
| id_cols = c("a", "b", "c"), | ||
| names_from = name, | ||
| values_from = value | ||
| ) | ||
| }) |
tests/testthat/test-pivot-wide.R
Outdated
|
|
||
| expect_snapshot(error = TRUE, { | ||
| pivot_wider( | ||
| df, |
Member
There was a problem hiding this comment.
This should be using df2, the tests aren't useful otherwise, looks like a thinko
tests/testthat/test-pivot-wide.R
Outdated
Comment on lines
892
to
906
| # Original issue scenario | ||
| x <- c(1, 2, 12, 31, 123, 2341) | ||
| df <- data.frame(x = x) | ||
|
|
||
| # This should produce a proper tidyselect error, not an internal error | ||
| expect_snapshot(error = TRUE, { | ||
| df %>% | ||
| dplyr::mutate(y = stringr::str_split(x, "")) %>% | ||
| unnest(cols = y) %>% | ||
| pivot_wider( | ||
| id_cols = x, | ||
| values_from = y, | ||
| names_from = x | ||
| ) | ||
| }) |
Member
There was a problem hiding this comment.
Simplified this pretty dramatically to a minimal reprex with meaningful comments
Member
|
I've gone ahead and updated everything, but I think Copilot did not do very well with these tests. I left comments above. |
Member
Author
|
Thanks for reviewing. This helps a lot in calibrating my expectations around autogenerating tests. I'll do another round myself next time. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1609
Closes #1482
Copilot wrote the code and the tests and hallucinated the snapshots. Fixed a syntax code in the test and updated snapshots. Looks legit to me now.